feat(x-for): dispatch change event when x-for create option element#4715
Open
ljk0071 wants to merge 3 commits intoalpinejs:mainfrom
Open
feat(x-for): dispatch change event when x-for create option element#4715ljk0071 wants to merge 3 commits intoalpinejs:mainfrom
ljk0071 wants to merge 3 commits intoalpinejs:mainfrom
Conversation
Contributor
|
🤔 This feels maybe too opinionated... since you could have logic associated with it changing...that this is now going to trigger... |
Author
|
After checking, I confirmed that @change was being triggered even when the x-model value remained the same. To address this, I’ve updated the logic to dispatch the change event only when the current value is missing from the updated options list. If you feel that triggering the event upon an x-model change is problematic, I’d like to share my perspective. I viewed this approach as being more aligned with the declarative nature that Alpine.js pursues, where the UI reacts naturally to state changes. |
Replaces manual :selected bindings for option elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2697
#4546
Fix x-model binding for select options rendered via x-for